Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2557

[cli][gradle] Adds package name as a global option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jim Schubert requested to merge package-name-globally into master Apr 01, 2019
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 9

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Extending on #2429, this adds package name globally in the CLI and Gradle Plugins. We have options for api package, model package, and invoker package globally. Configuring the three of these plus packageName in different locations can be confusing for the generators which support all four options.

There may be concern that packageName is made a "global" option and isn't supported by all generators, but there are quite a few options that aren't supported by many generators (e.g. all package related options, file post processing, etc). This favors usability in these cases.

I've opened #2556 for discussions about options which may or may not belong globally.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: package-name-globally