Created by: etherealjoy
Remove std::shared_ptr from the Qt5 generator Updated Petstore Update Object Template to be able to store the json body
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. -
Filed the PR against the correct branch: Default: master. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Summary of Changes
- Qt does not use shared_ptr for now, a reference of the object is passed, in the future even if we use this method we should use QSharedPointer. This is breaking the generator since wrong types are generated due to the use of base method to generate the parameter which by default uses std::shared_ptr.
- PetStore updated to use OAI generated types
- Object Template is updated to not return empty json body. cpp-qt5 can now accept an object and can also serialize an object like other langs. For derived types this is change is not impacting anything.
Fixes #256 (closed)
@stkrwork @MartinDelille @ravinikam @fvarose