Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !2951

[PHP] Fix group parameters in WithHttpInfo method

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged William Cheng requested to merge php_fix_group into master 6 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 3

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #2945 (closed)

Compare
  • master (base)

and
  • latest version
    abe62eac
    2 commits, 2 years ago

3 files
+ 3
- 3

    Preferences

    File browser
    Compare changes
modules/openapi-g‎enerator/…/…/…/php‎
api.mu‎stache‎ +1 -1
sam‎ples‎
client/petstor‎e/php/…/lib/Api‎
FakeA‎pi.php‎ +1 -1
openapi3/client/pe‎tstore/…/…/lib/Api‎
FakeA‎pi.php‎ +1 -1
modules/openapi-generator/src/main/resources/php/api.mustache
+ 1
- 1
  • View file @ abe62eac

  • Edit in single-file editor

  • Open in Web IDE


@@ -178,7 +178,7 @@ use {{invokerPackage}}\ObjectSerializer;
*/
public function {{operationId}}WithHttpInfo({{^vendorExtensions.x-group-parameters}}{{#allParams}}${{paramName}}{{^required}} = {{#defaultValue}}{{{.}}}{{/defaultValue}}{{^defaultValue}}null{{/defaultValue}}{{/required}}{{#hasMore}}, {{/hasMore}}{{/allParams}}{{/vendorExtensions.x-group-parameters}}{{#vendorExtensions.x-group-parameters}}$associative_array{{/vendorExtensions.x-group-parameters}})
{
$request = $this->{{operationId}}Request({{^vendorExtensions.x-group-parameters}}{{#allParams}}${{paramName}}{{#hasMore}}, {{/hasMore}}{{/allParams}}{{/vendorExtensions.x-group-parameters}}{{#vendorExtensions.x-group-parameters}}{{#allParams}}$associative_array['{{paramName}}']{{#hasMore}}, {{/hasMore}}{{/allParams}}{{/vendorExtensions.x-group-parameters}});
$request = $this->{{operationId}}Request({{^vendorExtensions.x-group-parameters}}{{#allParams}}${{paramName}}{{#hasMore}}, {{/hasMore}}{{/allParams}}{{/vendorExtensions.x-group-parameters}}{{#vendorExtensions.x-group-parameters}}$associative_array{{/vendorExtensions.x-group-parameters}});
try {
$options = $this->createHttpClientOption();
samples/client/petstore/php/OpenAPIClient-php/lib/Api/FakeApi.php
+ 1
- 1
  • View file @ abe62eac

  • Edit in single-file editor

  • Open in Web IDE


@@ -2807,7 +2807,7 @@ class FakeApi
*/
public function testGroupParametersWithHttpInfo($associative_array)
{
$request = $this->testGroupParametersRequest($associative_array['required_string_group'], $associative_array['required_boolean_group'], $associative_array['required_int64_group'], $associative_array['string_group'], $associative_array['boolean_group'], $associative_array['int64_group']);
$request = $this->testGroupParametersRequest($associative_array);
try {
$options = $this->createHttpClientOption();
samples/openapi3/client/petstore/php/OpenAPIClient-php/lib/Api/FakeApi.php
+ 1
- 1
  • View file @ abe62eac

  • Edit in single-file editor

  • Open in Web IDE


@@ -2841,7 +2841,7 @@ class FakeApi
*/
public function testGroupParametersWithHttpInfo($associative_array)
{
$request = $this->testGroupParametersRequest($associative_array['required_string_group'], $associative_array['required_boolean_group'], $associative_array['required_int64_group'], $associative_array['string_group'], $associative_array['boolean_group'], $associative_array['int64_group']);
$request = $this->testGroupParametersRequest($associative_array);
try {
$options = $this->createHttpClientOption();
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: PHP Issue: Bug
2
Client: PHP Issue: Bug
    Assign labels
  • Manage project labels

Milestone
4.0.1
4.0.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
William Cheng
Reference: OpenAPITools/openapi-generator!2951
Source branch: php_fix_group

Menu

Explore Projects Groups Snippets