Skip to content
GitLab

Only enable Spring default interface for `java8`

Merged Administrator requested to merge github/fork/eriktim/spring-interface-no-default into master

Created by: eriktim

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes #2984 (closed). The documentation of the java8 option describes it can be used to generate default interfaces. I therefore took the approach not to generate default interfaces when you don't explicitly set the java8 option. To me this feels the most natural. Please let me know if you prefer to add an extra option for this.

cc @diyfr