Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !3175

Fix rubocop obsolescence

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rhuanbarreto/patch-1 into master 6 years ago
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 3

Created by: rhuanbarreto

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @cliffano @zlx @autopp

Description of the PR

Rubocop gives an obsolescence error on linting the generated code

Error: The `Layout/FirstParameterIndentation` cop has been renamed to `Layout/IndentFirstArgument`.
(obsolete configuration found in .rubocop.yml, please update it)

This PR fixes it.

Compare
  • master (base)

and
  • latest version
    58cb862b
    5 commits, 2 years ago

3 files
+ 3
- 3

    Preferences

    File browser
    Compare changes
modules/…/…/…‎/…/ruby-client‎
rubocop.‎mustache‎ +1 -1
sam‎ples‎
client/pet‎store/ruby‎
.ruboc‎op.yml‎ +1 -1
openapi3/clien‎t/petstore/ruby‎
.ruboc‎op.yml‎ +1 -1
modules/openapi-generator/src/main/resources/ruby-client/rubocop.mustache
+ 1
- 1
  • View file @ 58cb862b

  • Edit in single-file editor

  • Open in Web IDE


@@ -46,7 +46,7 @@ Layout/EmptyLinesAroundMethodBody:
Layout/EmptyLinesAroundModuleBody:
Enabled: true
Layout/FirstParameterIndentation:
Layout/IndentFirstArgument:
Enabled: true
# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
samples/client/petstore/ruby/.rubocop.yml
+ 1
- 1
  • View file @ 58cb862b

  • Edit in single-file editor

  • Open in Web IDE


@@ -46,7 +46,7 @@ Layout/EmptyLinesAroundMethodBody:
Layout/EmptyLinesAroundModuleBody:
Enabled: true
Layout/FirstParameterIndentation:
Layout/IndentFirstArgument:
Enabled: true
# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
samples/openapi3/client/petstore/ruby/.rubocop.yml
+ 1
- 1
  • View file @ 58cb862b

  • Edit in single-file editor

  • Open in Web IDE


@@ -46,7 +46,7 @@ Layout/EmptyLinesAroundMethodBody:
Layout/EmptyLinesAroundModuleBody:
Enabled: true
Layout/FirstParameterIndentation:
Layout/IndentFirstArgument:
Enabled: true
# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: vinta/awesome-python!1636
Source branch: github/fork/rhuanbarreto/patch-1

Menu

Explore Projects Groups Snippets