Skip to content
GitLab

Ruby-client: Don't encode slashes if strict-spec false

Merged Administrator requested to merge github/fork/ccouzens/strictSpecBehaviorSlashEscape into master

Created by: ccouzens

--strict-spec false solution to https://github.com/OpenAPITools/openapi-generator/issues/3119

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @cliffano @zlx @autopp

Description of the PR

URL-special characters such as /,?,% should be encoded when inside path parameters. I changed the Ruby-client to do so. https://github.com/OpenAPITools/openapi-generator/pull/3039

Unfortunately, some projects relied on slashes not being expanded within path paramters: https://github.com/OpenAPITools/openapi-generator/issues/3119

With this commit, these projects can now pass --strict-spec false to not have / converted to %2F.

strict spec not specified: / -> %2F --strict-spec true: / -> %2F --strict-spec false: / -> /