Created by: ndbroadbent
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master,4.1.x,5.0.x. Default:master. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Hello! One of my customers was using my PHP client library, and they told me that it was crashing with an undefined variable (in some custom code that I added.) I write a set of integration tests that check that everything is working, and these tests were all passing, but I didn't know that PHP doesn't crash on undefined variables by default. I figured out that I can enforce this "strict" check by adding this option to the phpunit.xml file:
<ini name="error_reporting" value="E_ALL" />I'm not too familiar with PHP, but I think this behavior would probably be a sane default for anyone who wants to write tests for their PHP libraries.
CC
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09)