Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !341

Typescript Angular 2: Make service suffix configurable

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/beebase-gmbh/master into master Jun 18, 2018
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 8

Created by: tomvangreen

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

In earlier versions of the typescript-angular (2) swagger-codegen / openapi-generator, the suffix of the generated api servies was Api. This has been changed to Service in order to conform to angular naming guidelines.

For our project it makes sense that we can chose a different prefix in order to avoid naming collisions. For this I introduced 2 configuration parameters. serviceSuffix and serviceFileSuffix.

Service suffix is used as a suffix in the generated class name. Service file suffix is used as suffix in the file name (before the .ts extensions).

Technical comitee typescript: @TiFu, @taxpon, @sebastianhaas, @kenisteward, @Vrolijkx, @macjohnny #234 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/beebase-gmbh/master