Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !3495

[Core, Rust Server, ASP.NET Core] Fix Codegen Operation Scope Consistency

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Metaswitch/scope-consistency into master Jul 29, 2019
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 16

Created by: richardwhiuk

PR checklist

  • Read the contribution guidelines.

  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.

  • I've run both the Rust Server changes, and the ASP.NET petstore.sh scripts.

  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.

  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

    • Rust: @frol @farcaller @bjgill
    • ASP.NET: No technical committee exists.

Description of the PR

  • Filter scopes based on operation - this fixes https://github.com/OpenAPITools/openapi-generator/issues/1610

  • Partially revert #1984 to not rely on custom attributes as to whether scopes exist, and instead use built in Mustache function. - @MBcom you may be interested in the change here.

  • Tests are added to Rust Server codegen examples to check that the generated code is correct.

Code is by @mthebridge and @richardwhiuk . Any bugs are mine, any credit is Mark's 😄.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Metaswitch/scope-consistency