Created by: oponder
Intro
Hi! Thanks for this great project :D
This is a small PR to upgrade superagent in the generated javascript clients.
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master,4.1.x,5.0.x. Default:master. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Upgrade superagent to version 5.1.0, since versions lower than 3.8.1 have a security vulnerability. https://app.snyk.io/vuln/npm:superagent:20181108
We had been getting around this by manually editing the generated package.json each time. 5.1.0 seems like a big leap, but there appear to be no relevant breaking changes, at least not for our client: https://github.com/visionmedia/superagent#upgrading-from-previous-versions
So I believe this could be filed against master, but please correct me if I'm wrong!
Of course, I lack the full overview on what might break, so requesting a second pair of eyes, and confirmation here.
cc: @jfiala, @achew22, @jaypea
Regarding "Ran the shell script under ./bin/" from the PR checklist, I think I ran ./bin/javascript-petstore-all, ./bin/openapi3/javascript-es6-petstore.sh and ./bin/openapi3/javascript-closure-angular.sh
Does that cover it all? Wasn't sure about the right thing to do here.
Quite some more changes than expected came in though in the examples.