Skip to content
GitLab

Fix dart2 custom templates

Merged Administrator requested to merge github/fork/alexnavratil/fix-dart2-custom-templates into master

Created by: alexnavratil

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)

Description of the PR

setting a custom template directory using the dart client generator didn't work for dart 2.x since the templateDir gets overwritten by "dart2". Since the dart2 templates were outdated and still based on dartson (which isn't defined as dependency and also not working anymore), I've decided to fix them too (copied and fixed formatting from https://github.com/OpenAPITools/openapi-generator/pull/3048).

fixes https://github.com/OpenAPITools/openapi-generator/issues/3655

UPDATE: also fixes https://github.com/OpenAPITools/openapi-generator/issues/2830