Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !3752

[BUG][CLI][GENERATOR] NullPointer when not setting outputDir (updated)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jim Schubert requested to merge nullpointer-settings-fixes into master Aug 25, 2019
  • Overview 0
  • Commits 10
  • Pipelines 0
  • Changes 106

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Replaces #3448

  • WorkflowSettings now holds the same default values whether you create defaults via simple constructor (new WorkflowSettings) or via builder (WorkflowSettings.newBuilder()…build()).
  • Updates ruby petstore sample to have strictSpecBehavior=false to match outputs prior to 4.0.0.
  • Ensures that users can't "null out" fields that require values and have project-specified defaults.
  • Includes work by @Fjolnir-Dvorak to fix outputDir and updating of boolean values.
  • Adds a missed WorkflowSettings builder assignment when deserializing configs from json
  • Adds a test case to prevent a regression of #3439 (closed)

@OpenAPITools/generator-core-team

Ruby core team (@cliffano @zlx @autopp) fyi about the strictSpecBehavior=false config for sample output.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nullpointer-settings-fixes