typescript-fetch: add option for TypeScript 3.6+ compatible generation (!3801) · Merge requests · OpenAPI Tools / openapi-generator

Merged Administrator requested to merge github/fork/someone1/fix-3798 into master Aug 29, 2019

Created by: someone1

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The 3.6 release of typescript has some breaking changes that break the generated code. This PR updates the typescript-fetch generator to TypeScript 3.6 and replaces GlobalFetch with WindowOrWorkerGlobalScope.

I'd be happy to switch down to TypeScript 3.0 (I think this is the minimum version required for this change).

fixes #3798 (closed)

cc: @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)