Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !4010

[CSharp] add optional flag "optionalEmitDefaultValues" and update template

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/sdoeringNew/master into master 5 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 8

Created by: sdoeringNew

PR checklist

  • Read the contribution guidelines. But I'm unsure if I named the vendorExtension flag correctly. I do not put the csharp prefix as the other extensions in CSharp did not have this prefix, too.
  • Ran the shell script under ./bin/ to update Petstore sample for CSharp... But I haven't committed them because there were many other changes from previous template changes - so nobody seem to commit them. At least I saw that the flag worked as expected.
  • Filed the PR against the correct branch: master
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
  • Waited for the checks to have passed.

Description of the PR

This commit addresses issue #3274 (closed) and adds the proposed optionalEmitDefaultValues flag.

Invite cool reviewers

@mandrean (2017/08), @jimschubert (2017/09)

Compare
  • master (base)

and
  • latest version
    be9e115d
    1 commit, 2 years ago

8 files
+ 30
- 5

    Preferences

    File browser
    Compare changes
b‎in‎
open‎api3‎
csharp-property-c‎hanged-petstore.sh‎ +1 -1
win‎dows‎
csharp-property-ch‎anged-petstore.bat‎ +1 -1
csharp-property-c‎hanged-petstore.sh‎ +1 -1
docs/ge‎nerators‎
csha‎rp.md‎ +1 -0
modules/openapi-g‎enerator/src/main‎
java/org/opena‎pitools/codegen‎
lang‎uages‎
AbstractCShar‎pCodegen.java‎ +1 -0
CSharpClient‎Codegen.java‎ +20 -0
CodegenCon‎stants.java‎ +3 -0
resource‎s/csharp‎
modelGener‎ic.mustache‎ +2 -2
bin/openapi3/csharp-property-changed-petstore.sh
+ 1
- 1
  • View file @ be9e115d

  • Edit in single-file editor

  • Open in Web IDE


@@ -27,6 +27,6 @@ fi
# if you've executed sbt assembly previously it will use that instead.
export JAVA_OPTS="${JAVA_OPTS} -Xmx1024M -DloggerPath=conf/log4j.properties"
ags="generate $@ -i modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml -g csharp -o samples/client/petstore/csharp/OpenAPIClientWithPropertyChanged --additional-properties generatePropertyChanged=true --additional-properties packageGuid={5CD900DE-8266-412F-A758-28E1F9C623D5}"
ags="generate $@ -i modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml -g csharp -o samples/client/petstore/csharp/OpenAPIClientWithPropertyChanged --additional-properties generatePropertyChanged=true --additional-properties optionalEmitDefaultValues=true --additional-properties packageGuid={5CD900DE-8266-412F-A758-28E1F9C623D5}"
java $JAVA_OPTS -jar $executable $ags
bin/windows/csharp-property-changed-petstore.bat
+ 1
- 1
  • View file @ be9e115d

  • Edit in single-file editor

  • Open in Web IDE


@@ -5,6 +5,6 @@ If Not Exist %executable% (
)
REM set JAVA_OPTS=%JAVA_OPTS% -Xmx1024M
set ags=generate -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g csharp -o samples\client\petstore\csharp\SwaggerClientWithPropertyChanged --additional-properties=generatePropertyChanged=true,packageGuid={5CD900DE-8266-412F-A758-28E1F9C623D5}
set ags=generate -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g csharp -o samples\client\petstore\csharp\SwaggerClientWithPropertyChanged --additional-properties=generatePropertyChanged=true,optionalEmitDefaultValues=true,packageGuid={5CD900DE-8266-412F-A758-28E1F9C623D5}
java %JAVA_OPTS% -jar %executable% %ags%
bin/csharp-property-changed-petstore.sh
+ 1
- 1
  • View file @ be9e115d

  • Edit in single-file editor

  • Open in Web IDE


@@ -27,6 +27,6 @@ fi
# if you've executed sbt assembly previously it will use that instead.
export JAVA_OPTS="${JAVA_OPTS} -Xmx1024M -DloggerPath=conf/log4j.properties"
ags="generate -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g csharp -o samples/client/petstore/csharp/OpenAPIClientWithPropertyChanged --additional-properties generatePropertyChanged=true --additional-properties packageGuid={5CD900DE-8266-412F-A758-28E1F9C623D5} $@"
ags="generate -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g csharp -o samples/client/petstore/csharp/OpenAPIClientWithPropertyChanged --additional-properties generatePropertyChanged=true --additional-properties optionalEmitDefaultValues=true --additional-properties packageGuid={5CD900DE-8266-412F-A758-28E1F9C623D5} $@"
java $JAVA_OPTS -jar $executable $ags
docs/generators/csharp.md
+ 1
- 0
  • View file @ be9e115d

  • Edit in single-file editor

  • Open in Web IDE


@@ -21,6 +21,7 @@ sidebar_label: csharp
|returnICollection|Return ICollection<T> instead of the concrete type.| |false|
|optionalMethodArgument|C# Optional method argument, e.g. void square(int x=10) (.net 4.0+ only).| |true|
|optionalAssemblyInfo|Generate AssemblyInfo.cs.| |true|
|optionalEmitDefaultValues|Set DataMember's EmitDefaultValue.| |false|
|optionalProjectFile|Generate {PackageName}.csproj.| |true|
|generatePropertyChanged|Specifies a AssemblyDescription for the .NET Framework global assembly attributes stored in the AssemblyInfo file.| |false|
|nonPublicApi|Generates code with reduced access modifiers; allows embedding elsewhere without exposing non-public API calls to consumers.| |false|
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java
+ 1
- 0
  • View file @ be9e115d

  • Edit in single-file editor

  • Open in Web IDE


@@ -39,6 +39,7 @@ import static org.openapitools.codegen.utils.StringUtils.camelize;
public abstract class AbstractCSharpCodegen extends DefaultCodegen implements CodegenConfig {
protected boolean optionalAssemblyInfoFlag = true;
protected boolean optionalEmitDefaultValuesFlag = false;
protected boolean optionalProjectFileFlag = true;
protected boolean optionalMethodArgumentFlag = true;
protected boolean useDateTimeOffsetFlag = false;
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
Client: C-Sharp Enhancement: Feature
2
Client: C-Sharp Enhancement: Feature
    Assign labels
  • Manage project labels

Milestone
4.2.0
4.2.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
Jim Schubert
Reference: OpenAPITools/openapi-generator!4010
Source branch: github/fork/sdoeringNew/master

Menu

Explore Projects Groups Snippets