Created by: nickmeinhold
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/to update Petstore sample so that CIs can verify the change. -
Filed the PR against the correct branch: master -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. - @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)
Description of the PR
fixes #3816 (closed)
Currently there are no tests run by CI for the second stage of the code generation (the templates). I found a set of tests for the petstore api client library that were previously disabled, presumably as they were hitting the live endpoint and so were flaky.
I wrote a fake http client and recorded some of the responses from the live server so the tests don't use a live endpoint. So currently the only tests are e2e tests that were adapted to use stubbed responses. While pushing data around as a smoke test might have some value, more testing is required. This is at least a step in the right direction.