Skip to content
GitLab

[Rust] Handle optional and nullable parameters

Merged Administrator requested to merge github/fork/bcourtine/optional_parameters_3052 into master

Created by: bcourtine

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

/cc @jonahgeorge @wing328 @frol @farcaller @bjgill @richardwhiuk

Description of the PR

Fix #3052 (closed). This PR is based on @jonahgeorge work. It follows (and replace) PR #3250.

This PR includes theses changes:

  • Handling "optional" parameters is not optional anymore. Handling an additional parameter for it makes templates more complicated, and IMO, it is not worth it (as discussed in issue, it is an "acceptable" breaking change).
  • Optional parameters are handled everywhere: path params, query params, form params... Generated sample code compiles (both hyper and reqwest libraries).
  • For now, nullable attribut is not handled.