Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !4238

[kotlin][client] only use authentication tokens when they are not null

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/4brunu/feature/kotlin-client-bearer-authentication into master Oct 23, 2019
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 10

Created by: 4brunu

When using bearer authentication or oauth, the tokens are used even if they are null.

Here is the generated code:

    protected fun updateAuthParams(requestConfig: RequestConfig) {
        if (requestConfig.headers[Authorization].isNullOrEmpty()) {
            requestConfig.headers[Authorization] = "Bearer " + accessToken
        }
    }

The problem is that if accessToken is null, the header "Authentication" will have the value "Bearer null" and the server will return Http Status Code 500 instead of 401.

Instead of the above code, I suggest generating something like this.

    protected fun updateAuthParams(requestConfig: RequestConfig) {
        if (requestConfig.headers[Authorization].isNullOrEmpty()) {
            accessToken?.let { accessToken ->
                requestConfig.headers[Authorization] = "Bearer " + accessToken
            }
        }
    }

Fixes https://github.com/OpenAPITools/openapi-generator/issues/4237

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/4brunu/feature/kotlin-client-bearer-authentication