Created by: mtraynham
Most of the Kotlin generator templates loop requiredVars and optionalVars (1, 2) . Unfortunately, it looks like during the CodegenModel.removeAllDuplicatedProperty, the CodegenProperty's are all cloned and therefore the current implementation of only updating the allVars list isn't sufficient to reflect that in requiredVars or optionalVars.
All 3 lists (allVars, requiredVars, optionalVars) should be updated with the isInherited property.
Also, the KotlinSpringServerCodegen was doing the same thing as AbstractKotlinCodegen so I removed it.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.1.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@jimschubert @dr4ke616 @karismann @Zomzog