Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !4381

[csharp-netcore] Propagate raw content to the ApiException error content.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/yzhoholiev/master into master Nov 05, 2019
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 9

Created by: yzhoholiev

This PR resolves an issue with the ApiException error content described in #3473 (closed) .

The issue is linked to migration to the generic IRestResponse<T>. The deserialization happens before the exception is actually checked by ExceptionFactory.

Possible fix is to propagate both raw response content from IRestResponse.Content as well as IRestResponse<T>.Data to the ApiResponse.

But I think it makes sense to roll back to the older implementation, where deserialization happed if an exception hadn't been constructed.

Technical committee: @mandrean (2017/08), @jimschubert (2017/09) ❤️ @frankyjuang (2019/09)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/yzhoholiev/master