Skip to content
GitLab

[dart-dio] Fixes some instances of List or Map by replacing with Built equivalents

Merged Administrator requested to merge github/fork/josh-burton/dart-dio-builtlist-fix into master

Created by: josh-burton

Fixes issue where only some instances of List or Map were replaced with Built equivalents

If there was a type that had a nested type of List or Map, e.g. Map<String, List<String>> only the outer types would be replaced with the Built variants, causing issues when running the builder.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @ircecho @swipesight @jaumard @nickmeinhold