Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !4711

typescript-fetch: Fix compatibility with noImplicitAny TS rule

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dngconsulting/master into master Dec 05, 2019
  • Overview 0
  • Commits 9
  • Pipelines 0
  • Changes 9

Created by: dngconsulting

Why this PR

runtime.ts file generated by typescript-fetch template doesn't meet the needs of Typescript rule "noImplicitAny" that requires that any function should return an object with its type. With the current version, the user gets a compile error and it's not possible to fix this error by removing the TS rule. In CRA (Create React Apps and react-script) this rule is kind of "hardcoded" in tsconfig.json. The rules are overridden each time a compilation is raised.

How it solve the issue ?

Just by adding the correct return types. It doesn't break anything in the current code, it just ensures that correct types will be returned.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dngconsulting/master