Skip to content
GitLab

[go-experimental] Fix issue with Nullable marshaling comparing value to empty string no matter the enum type

Merged Administrator requested to merge github/fork/zippolyte/hippo/go_nullable into master

Created by: zippolyte

For enum models, there was a hardcoded v.Value != "" in the template, where v.Value could be any type, so the code wouldn't compile. This PR removes this to make the marshaling function identical with non-enum types, and removes the duplication.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)