Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !4768

[C-libcurl] fix building error when complexType is empty.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ityuhui/yhworking into master Dec 11, 2019
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: ityuhui

[C-libcurl] Change "complexType" to "name" inner "isMapContainer" to fix building error when complexType is empty.

When generating k8s C-libcurl client, there is a build error due to the duplicated List

They are generated by the below template code:

{{#isMapContainer}}
    list_t *{{{complexType}}}List;
...
{{/isMapContainer}} 

But for my case, complexType is empty, so there are some duplicated List

list_t *List;
...
list_t *List;
...
list_t *List;

They will cause building error.

I checked other parts inner the {{#isMapContainer}} and {{/isMapContainer}} in the same file, and found "complexType" should be changed to "name"

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the master: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @PowerOfCreation @zhemant

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ityuhui/yhworking