This addresses my comments discussed in #4872
Specifically, I override type/property evaluation and default values so that Set is used consistently across models and properties. I've also added tests.
If CI passes here, I think we can close #4872 and merge into master. I would consider Arrays with unique items generating as List rather than Set to be a bug rather than a breaking change. @wing328 would you agree?
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @clasnake @shijinkui @ramzimaalej