Created by: sebastien-rosset
This PR addresses the following:
- The generated go-experimental code is not compiling in some cases.
- Use an embedded struct to model the codegen parent
- The instantiation type of a parent of "map" type is incorrect
In particular, the generated samples/openapi3/client/petstore/go-experimental/go-petstore/api_fake.go file has the following code:
t := *r.pipe
if reflect.TypeOf(t).Kind() == reflect.Slice {
....
}
....
t := *r.contextAs you can see, the same variable "t" is defined twice, which causes a compilation error:
go-petstore/api_fake.go:1782:4: no new variables on left side of :=This PR depends on #5075.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.