Skip to content
GitLab

[dart-dio] Various fixes

Merged Administrator requested to merge github/fork/daohoangson/dart-dio/k8s into master

Created by: daohoangson

This PR includes a few different fixes:

  • Add missing import, serializer for dateLibrary=timemachine
  • Remove bad import package:http/io_client.dart
  • Use raw strings for those that contain variable name. This should eliminate potential issue with variables like $ref.
  • Use _path instead of path to avoid potential conflict with op params.

These fixes are required when I try to generate for Kubernetes API (example json here).

Please note that this PR needs another PR to work properly (https://github.com/google/built_value.dart/pull/804).

CC @ircecho @swipesight @jaumard @nickmeinhold @athornz @amondnet

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.