Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5033

[CORE] replace http with https. Replace http://central.maven.org with https:repo1.maven.org

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/CiscoM31/maven-https into master Jan 18, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 706

Created by: sebastien-rosset

Trying to eliminate the use of http as much as possible. Some of these changes are documentation only and do not affect the build but we should use https nonetheless. There are multiple use of http://central.maven.org, but that site returns error 403 with a message stating to use http://repo1.maven.org. I've replaced these.

There are some http URL that don't exist anymore. I'm not sure what to do about it, and it's not clear they are used anyway.

I did a cursory search to find use of http://:

grep -r 'http://'  . | grep -v xmlns |grep -v schemaLocation   | wc

Right now it yields over 6000 results. Unfortunately we can't do a simple search and replace.

Slightly better way to find references to http://

grep -r 'http://'  . | grep -v xmlns |grep -v schemaLocation  | sed -rn 's/.*(http:\/\/[^ )"]+).*/\1/p' | sort | uniq

It yields 779 results.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/CiscoM31/maven-https