Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5057

[typescript-axios] Fixed call of toISOString on a string type when using string type-mapping

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/LiamMartens/typescript-axios-datetime-toisostring into master Jan 20, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: LiamMartens

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo

Created a detailed repro repository here

Basic gist of it is the following, let's assume you have following swagger definition

"parameters": [
    {
        "name": "param",
        "in": "query",
        "required": false,
        "type": "string",
        "format": "date-time"
    }
],

When type mapping date to string this results in the following generated code

example(param?: string, options: any = {}): RequestArgs {
    ....
    if (param !== undefined) {
        localVarQueryParameter['param'] = (param as any).toISOString(); <-- toISOString() on string type
    }
    ...
},

This same fix was applied to the isDate template.

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [x ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [x ] File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • [x ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/LiamMartens/typescript-axios-datetime-toisostring