Created by: ccouzens
btoa (binary to ascii), is a javascript function to base64 encode a string.
Axios is usable both from node and from the browser. But the btoa function is available only in the browser.
This meant that any client that used basic auth was broken in node. Axios has its own method of encoding basic auth credentials. This method works in both the browser and node. https://github.com/axios/axios/blame/v0.19.2/README.md#L318
By using this method, the generated client works in node and in the browser.
This solves this comment on this issue. https://github.com/OpenAPITools/openapi-generator/issues/3049#issuecomment-498278966
I have validated this change within a personal project: https://github.com/ccouzens/create-vdc-with-edge-portal-api-demo/commit/df8b552f5f8b7528bd0b003b1c5b5558dd05eabf#diff-e91249994e03dd6af8c6bee4ff7d8381
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.