Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5154
An error occurred while fetching the assigned milestone of the selected merge_request.

[Python] Python HTTP signature update

  • Review changes

  • Download
  • Email patches
  • Plain diff
Administrator requested to merge github/fork/CiscoM31/python-http-signature-2 into master 5 years ago
  • Overview 0
  • Commits 11
  • Pipelines 0
  • Changes 14

Created by: sebastien-rosset

This PR is a follow up to the initial commit for HTTP signature support, based on additional testing and review.

  • The OAuth2 "access_token" value should be null by default, not empty string. Otherwise, the client will attempt to set the "Authorization" header with an empty bearer token.
  • Added more documentation.
  • Conditionally generate the examples in the Configuration() object, based on what security schemes are defined in the OAS spec.
  • In the Configuration examples, add snippet of OAS spec with a security scheme to better explain the use cases.
  • Add missing import
  • Fix typo

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Approval is optional

Merge details

  • 13 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity


Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/CiscoM31/python-http-signature-2

Menu

Explore Projects Groups Snippets