Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5211

[kotlin][client] respect sortModelPropertiesByRequiredFlag

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/4brunu/feature/kotlin-model-parameters-order into master Feb 05, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: 4brunu

https://github.com/OpenAPITools/openapi-generator/pull/4707 introduced a flag sortModelPropertiesByRequiredFlag to control how the model orders the properties to fix https://github.com/OpenAPITools/openapi-generator/issues/4705.

By default the model properties already are sorted by the required here https://github.com/OpenAPITools/openapi-generator/blob/4fa096f604bfe138a7ea6d3a426cfd3caed473ad/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java#L76

And the user can choose if he wants to sort the model properties already by the required or not here https://github.com/OpenAPITools/openapi-generator/blob/4fa096f604bfe138a7ea6d3a426cfd3caed473ad/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java#L200

With https://github.com/OpenAPITools/openapi-generator/pull/4453 this become non functional.

This PR restores this functionality.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/4brunu/feature/kotlin-model-parameters-order