Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !528

[Rust] Split out request logic, implement form parameters

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/euank/rust-split-out-request-making into master Jul 10, 2018
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 12

Created by: euank

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change.
  • Copied the technical committee

cc @frol @farcaller @bjgill

Description of the PR

This PR contains two changes which I needed to make for a particular swagger client to work.

The first moves most request logic into a standalone file / method. This makes it much erasier to avoid variable conflicts since the Request.execute method doesn't have the generated params in its scope, and as such doesn't have to worry about conflicting with them.

I intend for .execute to behave identically to what we previously generated per operation.

I did, however, also implement form data while I was at it. That is included as a second separate commit, and I can file it separately if that's preferred.

Fixes #512 (closed), #525 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/euank/rust-split-out-request-making