Skip to content
GitLab

typescript-fetch: Base Path can't be set to empty string

Merged Administrator requested to merge github/fork/duxiaofeng-github/master into master

Created by: duxiaofeng-github

fixes #5282 (closed), allows developer to set base_path to an empty string.

The code check the this.configuration.basePath, if it's NOT A NULL OR UNDEFINED, then use this.configuration.basePath, otherwise use the BASE_PATH

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.