Skip to content
GitLab

[BUG][typescript-rxjs] Fix nully type coalescing in Configuration getters

Merged Administrator requested to merge github/fork/ermik/fix-config-getter-typecheck into master

Created by: ermik

With Typescript 3.7.5 the runtime.ts template output produces the following error:

(50,9): Type ‘“” | ((name: string) => string) | undefined’ is not assignable to type ‘((name: string) => string) | undefined’.
      Type ‘“”’ is not assignable to type ‘((name: string) => string) | undefined’.

referring to the coalescing of the null "" JS value in the following lines: https://github.com/OpenAPITools/openapi-generator/blob/118b5e77473c80eb0e3cbea1413ecf27075c19e3/modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache#L39 https://github.com/OpenAPITools/openapi-generator/blob/118b5e77473c80eb0e3cbea1413ecf27075c19e3/modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache#L44

Additionally, the typeof accessToken === 'function' check opens the discussion about polymorphism, while checking against "string" is more obvious — thus capturing the string half of the union type and leaving the rest of it to the TS inference to make sense of.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)