Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5341

[python] Adds python oneOf/anyOf models + tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/spacether/adds_python_composedschema_tests into master Feb 16, 2020
  • Overview 0
  • Commits 7
  • Pipelines 0
  • Changes 186

Created by: spacether

This adds openapi (v3 spec) samples and tests in the python-experimental client These additions + fixes verify that composed schemas are working in the python-experimental client.

We have added the following models:

  • fruit (composed oneOf with optional properties, no discriminator)

    • apple a oneOf class in fruit
    • banana a oneOf class in fruit
  • mammal (composed oneOf with optional properties, HAS discriminator)

    • whale a oneOf class in mammal
    • zebra a oneOf class in mammal
  • gmFruit a composedschema anyOf class with no discriminator

  • fruitReq a composedschema oneOf class with required properties in its oneOf schemas no discriminator

    • appleReq a oneOf schema in fruitReq
    • bananaReq a oneOf schema in fruitReq

Verification Tests

  • fruit model, composed oneOf with optional properties, no discriminator
  • fruitReq model, composedschema oneOf class with required properties in its oneOf schemas no discriminator
  • gmFruit model composedschema anyOf class with no discriminator
  • mammal deserialization composed oneOf with optional properties, HAS discriminator

Related Issues

  • https://github.com/OpenAPITools/openapi-generator/issues/1919
  • https://github.com/OpenAPITools/openapi-generator/issues/453
  • https://github.com/OpenAPITools/openapi-generator/issues/1920
  • https://github.com/OpenAPITools/openapi-generator/issues/1663
  • https://github.com/OpenAPITools/openapi-generator/issues/1662
  • https://github.com/OpenAPITools/openapi-generator/issues/623
  • https://github.com/OpenAPITools/openapi-generator/issues/453

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Python Technical Committee: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @slash-arun (2019/11) @spacether (2019/11)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/spacether/adds_python_composedschema_tests