Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5356

[C-libcurl] Guard memory free for query parameters to avoid coredump

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ityuhui/yhworking into master Feb 18, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ityuhui

After generating a C-libcurl client for kubernetes and linking with my program, a coredump will happen due to deleting an un-allocated memory

Program received signal SIGSEGV, Segmentation fault.
__GI___libc_free (mem=0x3000000030) at malloc.c:2951
2951    malloc.c: No such file or directory.
(gdb) bt
#0  __GI___libc_free (mem=0x3000000030) at malloc.c:2951
#1  0x00000000004290a0 in CoreV1API_listCoreV1NamespacedSecret (apiClient=0x6b4570, namespace=0x488489 "default", 
    pretty=0x0, allowWatchBookmarks=0, _continue=0x0, fieldSelector=0x0, labelSelector=0x0, limit=0, 
    resourceVersion=0x0, timeoutSeconds=1000, watch=0) at /root/c_k8s_api_client/api/CoreV1API.c:16598
#2  0x0000000000401532 in listSecret () at main.c:77
#3  0x000000000040179f in main (argc=2, argv=0x7fffffffe0a8) at main.c:159

The coredump happens at:

    free(keyQuery_pretty);

But actually, keyQuery_pretty is not allocated.

So I added some guards for the query parameters before memory free.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the master: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ityuhui/yhworking