Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5509

[Java] Update version of maven-surefire-plugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/CiscoM31/maven-surefire into master Mar 03, 2020
  • Overview 0
  • Commits 29
  • Pipelines 0
  • Changes 7

Created by: sebastien-rosset

  1. Upgrade version of maven-surefire-plugin
  2. In case of UT failure, output logs of petstore service to help troubleshoot issue.
  3. Java unit tests are modified to use the local instantiation of the petstore.

Currently, the default "okhttp-gson" library uses maven-surefire-plugin version 2.12, which is fairly old (January 2012). With maven-surefire-plugin version 2.12, the following error occurs when executing "mvn package" on the generated Java code:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test
(default-test) on project intersight-openapi-java-client:
Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test failed:
Task java.util.concurrent.FutureTask@f29353f[Not completed, task = org.apache.maven.plugin.surefire.booterclient.ForkStarter$1@889a8a8] rejected
from java.util.concurrent.ThreadPoolExecutor@36f7d7b[Running, pool size = 1,
active threads = 0, queued tasks = 500, completed tasks = 0] -> [Help 1]

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test
(default-test) on project intersight-openapi-java-client: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.12:test failed:
Task java.util.concurrent.FutureTask@f29353f[Not completed, task = org.apache.maven.plugin.surefire.booterclient.ForkStarter$1@889a8a8]
rejected from java.util.concurrent.ThreadPoolExecutor@36f7d7b[Running, pool size = 1,
active threads = 0, queued tasks = 500, completed tasks = 0]

This issue occurs with relatively big OAS documents.

Changing the pom.xml to use version 3.0.0-M4 fixes the problem.

For reference, here is the bug fix in the surefire plugin: https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=b7adb745df68730e43a6e3e4711f18619513bfb0

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/CiscoM31/maven-surefire