Skip to content
GitLab

[Rust Server] Retire mimetypes modules

Merged Administrator requested to merge github/fork/Metaswitch/rust-server-retire-mimetypes into 5.0.x

Created by: richardwhiuk

This removes the mimetypes module, because:

  • it doesn't really add any value (it used to when we used lazy_static! to initialise MimeType structs but they're not just &strs)
  • it's possible to get collisions in the identifiers.

This fix was contributed by @mirw and reviewed by myself on behalf of @Metaswitch.

Rust Server Technical Committee

  • @frol
  • @farcaller
  • @bjgill

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.