Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5626

[C][Client] Check the pointer before deleting operation to avoid core dump

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ityuhui/yhworking into master Mar 18, 2020
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 9

Created by: ityuhui

The c client code snippet that I generate using OpenAPI c generator ( master branch ) is below:

void v1_pod_spec_free(v1_pod_spec_t *v1_pod_spec) {
    v1_affinity_free(v1_pod_spec->affinity); <-- If v1_pod_spec is null, program will coredump here
...
}

void list_free(list_t *list) {
      list_iterateThroughListForward(list, listEntry_free, NULL);   <-- If list is null, program will coredump here.
      free(list);
}

So I add some guard, now the code becomes:

void v1_pod_spec_free(v1_pod_spec_t *v1_pod_spec) {
    if(NULL == v1_pod_spec){  <-- now if v1_pod_spec is null, the function will return.
       return ;
    }    
    v1_affinity_free(v1_pod_spec->affinity);
...
}

void list_free(list_t *list) {
      if(list){   <-- now if list is null, the function will bypass this code.         
          list_iterateThroughListForward(list, listEntry_free, NULL);
          free(list);
      }
}

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ityuhui/yhworking