Created by: amakhrov
Fixes a regression reported here https://github.com/OpenAPITools/openapi-generator/issues/927 (although originally that was a broader issue, not just typescript-specific)
allParents is used by generators with multiple inheritance, e.g typescript and perl.
Earlier there was an attempt to bring parent and allParents in sync: https://github.com/OpenAPITools/openapi-generator/pull/5182
Turned out it's not a robust approach, as it had duplicated logic in two methods. And a later change un-synced the two methods again (https://github.com/OpenAPITools/openapi-generator/pull/5526/files#diff-57d7532cf464a8d7c24aab4b22ceb993R1138)
This PR eliminates logic duplication (well, to some degree) and simply appends parent to the list of allParents if it was not there yet.
Note that there is no sample change. This reflects the sad fact that existing typescript samples don't cover inheritance cases.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)