Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5837

C client generator improvements to support petstore

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/michelealbano/Cimproves into master Apr 06, 2020
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 25

Created by: michelealbano

To fix #5836 (closed)

Improvement to the C client generator, driven by: openapi-generator/modules/openapi-generator/src/test/resources/3_0/petstore.yaml

In particular:

  • A .h and a .c to manage binary data, like it's done for lists
  • Correct allocation of data for binary data in the model body
  • Encode/decode of binary data when OPENSSL is not in use
  • Correct creation of tests for binary data
  • Added an "example" for patterns
  • Decoration of apiKeys in apiClient, needed when a yaml has got both auth_cookie and api_key

Now the generator can support that API definition, comprising creation of test files for the models.

@ityuhui @zhemant @wing328

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • [ X ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/michelealbano/Cimproves