Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5850

[BUG] [TYPESCRIPT-AXIOS] Fixing issue where dist folder is not published

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/MalcolmScoffable/typescript_axios_build_fix into master Apr 07, 2020
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 15

Created by: MalcolmScoffable

This pull requests fixes the issue described in https://github.com/OpenAPITools/openapi-generator/issues/3224 where the dist folder is not published when the npm publish command is run. This appears to be because the dist folder is included in the .gitignore. This PR removes the dist entry from gitignore which ensures that the dist folder is included and that generated libraries can be safely published to npm etc.

fixes #3224 (closed)

Without this fix, the generated library works when linked locally but not when published, ensuing in much confusion.

PR checklist

  • Read the contribution guidelines.

  • If contributing template-only or documentation-only changes which will change sample output, build the project before.

  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).

  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.

  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

  • Copying technical committee CC @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MalcolmScoffable/typescript_axios_build_fix