Created by: sebastien-rosset
- Case sensitivity
The OpenAPI specification explicitly states field names are case sensitive:
All field names in the specification are case sensitive. This includes all fields that are used as keys in a map, except where explicitly noted that keys are case insensitive.
That includes discriminator values. The discriminator value lookup must be case sensitive by default. Adding a property to support case insensitive lookup.
- Incorrect class name in generated discriminator lookup.
In the generated JSON.java file, there is a lookup function that takes a string as input and returns the name of the Java class. The map incorrectly uses the name of the Java class to register the mapping in classByDiscriminatorValue. This isn't a problem if the OAS document has a name that does not require sanitization (e.g. "Animal"), but for example "animal" would be converted to "Animal" when creating a Java class.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.