Created by: famod
Fixes #5862 (closed).
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)
The change to CodegenConfigurator looks more than it really is. I just pulled out everything that is related to actually parse the file into a synchronized method to resolve the following concurrency issue: https://github.com/OpenAPITools/openapi-generator/issues/5862#issuecomment-611023874
I must say though, that the existing approach to mutate a singleton ObjectMapper seems rather dodgy.
Before my change, I was able to provoke the issue in my current project (which I am not allowed to share) after max. 30 mins via:
time while mvn -T2 openapi-generator:generate@generate-code -pl moduleA,moduleB -Dopenapi-generator-maven-plugin.version=4.3.1-SNAPSHOT; do :; doneAfter my change I stopped the loop after 2 hours.