Skip to content
GitLab

Fix #5026: don't add @NotNull annotation if property is readOnly.

Closed Administrator requested to merge github/fork/tty0482/master into master

Created by: tty0482

This is a simple fix for issue #5026 (closed) that works by changing the beanValidation template to only annotate with @ NotNull if required is set and isReadOnly is not set.

Copy for review: @bbdouglas @sreeshas @jfiala @lukoyanov @cborn @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.