Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !5995

[typescript-fetch] Fix map API return type

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/haraldF/haraldf-map into master 5 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: haraldF

Fix APIs that return a map.

given the following schema (yaml) as the application/json body of an API:

    Foo:
      type: object
      additionalProperties:
        $ref: '#/components/schemas/Bar'

The generator generated the wrong code that wouldn't transpile. This PR fixes that by handling maps the same way as we handle maps in other places.

PR checklist

  • [ X ] Read the contribution guidelines.
  • [ X ] If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • [ X ] Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • [ X ] File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • [ X ] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Activity

Please register or sign in to reply

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines.

0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
Client: TypeScript
1
Client: TypeScript
    Assign labels
  • Manage project labels

Milestone
4.3.1
4.3.1 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: OpenAPITools/openapi-generator!5995
Source branch: github/fork/haraldF/haraldf-map

Menu

Explore Projects Groups Snippets