Created by: ermik
This reverts (by improving) a change by @denyo in #4250, which I spoke to him in the review comment. In my opinion, if this change is accepted, it should be adopted by the rest of typescript templates.
- previously clone() and its clients in the BaseAPI class were generic
- with removal of the generic argument, these methods became unavailable to the API classes inheriting from BaseAPI
- original generic was imprecise, as these are not statics
- return type of
thisis the correct notation
Additionally, @denyo requested I add some of the changes he has PRed in #5465 to avoid future conflict. I agree with the destructuring change and have included it. I've left a couple of comments in his PR with my take on the ternary usage.
NB: Apologies for force pushes, the local environment has created a flawed starting point.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)