Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openapi-generator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,476
    • Issues 3,476
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 402
    • Merge requests 402
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenAPI Tools
  • openapi-generator
  • Merge requests
  • !605

[Java][Client][RestTemplate] Do not create new Object for empty body

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/rubms/#513 into master Jul 19, 2018
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 9

Created by: rubms

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixed issue #513 (closed), introduced in pull request https://github.com/OpenAPITools/openapi-generator/pull/98. While the change introduced in https://github.com/OpenAPITools/openapi-generator/pull/98 is appropriate for many java client libraries, that directly serialize via Jackson or Gson, it breaks the RestTemplate generation (as RestTemplate relies on message converters and these are not able to serialize java.lang.Objects.

This PR rolls https://github.com/OpenAPITools/openapi-generator/pull/98 back exclusively for the RestTemplate client library.

cc @jmini @bmordue @macjohnny @bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rubms/#513