Created by: spacether
Adds memoization with the decorator cached_property and deserialization through 2 or more discriminators in python-experimental
Memoization should decrease the deserialization time through complex schemas
The discriminator logic picking a different model to instantiate has been moved to the __new__ method.
- tests have been added demonstrating the discriminator deserialization through 2 discriminators
@ethan92429 this may solve the problem you were having where deserialization takes a while
This PR along these:
- [MERGED] Improve composed schema discriminator map
- [IN REVIEW] Use the ancestor discriminator dict if the key/value pair is not found in the current discriminator
Should resolve https://github.com/OpenAPITools/openapi-generator/issues/4912
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
Python Technical committee: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @slash-arun (2019/11) @spacether (2019/11)
@sebastien-rosset
This PR: https://github.com/OpenAPITools/openapi-generator/pull/5809 also touches python-experimental discriminator code and is in review