Created by: natanlaverde
Change helper method writeResponseHeaders implementation to just set the headers, instead of write them, and also rename the method to setSocketResponseHeaders, to maintain the new semantic.
The implementation of QHttpEngine::Socket::write or QHttpEngine::Socket::writeJson implementations will call Socket::writeData that writes the Headers and Status Code before write the content if they are not already written.
If these methods are not called (e.g.: empty reply), we could set the headers just before close the socket.
Fixes #6344 (closed) cc @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project before. -
Run the shell script(s) under ./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc). -
File the PR against the correct branch: master,4.3.x,5.0.x. Default:master. -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.